Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subsys: net: lib: downloader: make sure at least one transport enabled #19823

Merged
merged 1 commit into from
Jan 15, 2025
Merged

subsys: net: lib: downloader: make sure at least one transport enabled #19823

merged 1 commit into from
Jan 15, 2025

Conversation

eivindj-nordic
Copy link
Contributor

The downloader library require at least one transport to be enabled. Add build assert when downloader library is enabled without any transport.

@eivindj-nordic eivindj-nordic self-assigned this Jan 9, 2025
@eivindj-nordic eivindj-nordic requested a review from a team as a code owner January 9, 2025 14:06
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 9, 2025
@eivindj-nordic eivindj-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 9, 2025
@eivindj-nordic eivindj-nordic force-pushed the downloader_log_no_transport branch from b71352c to dd2bf19 Compare January 9, 2025 14:09
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 9, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 9, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 0de505b3d5c832e4f4be5d8f0af1b1b021a414d2

more details

sdk-nrf:

PR head: 0de505b3d5c832e4f4be5d8f0af1b1b021a414d2
merge base: 5ae88098dfb7279a30f153eb9b7f06ff691ba60c
target head (main): aec6383d2d31332319493bab8b5364d62f0fad8a
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1) 
subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── downloader
│  │  │  │  │ dl_transports.ld

Outputs:

Toolchain

Version: 11349092be
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:11349092be_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 363
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ⚠️ test-fw-nrfconnect-fw-update
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
    • ⚠️ test-fw-nrfconnect-nrf-iot_lwm2m
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@eivindj-nordic eivindj-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 10, 2025
@eivindj-nordic
net: lib: downloader: make sure at least one transport enabled
0de505b 
The downloader library require at least one transport to be enabled.
Add build assert when downloader library is enabled without any
transport.

Signed-off-by: Eivind Jølsgard <[email protected]>
@eivindj-nordic eivindj-nordic force-pushed the downloader_log_no_transport branch from dd2bf19 to 0de505b Compare January 13, 2025 12:32
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 13, 2025
@nordicjm nordicjm merged commit c5a2aac into nrfconnect:main Jan 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhmolt anhmolt anhmolt approved these changes

@MirkoCovizzi MirkoCovizzi MirkoCovizzi approved these changes

@tokangas tokangas tokangas approved these changes

Assignees

@eivindj-nordic eivindj-nordic

Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eivindj-nordic @NordicBuilder @tokangas @MirkoCovizzi @anhmolt @nordicjm